fix: ledger hardware wallet support on mac#223
Merged
Conversation
felipe-op
force-pushed
the
felipe/ledger
branch
from
ce564a6 to
7f23da6
Compare
protolambda
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes Ledger hardware wallet discoverability on Macos 14.
Error:
Debugging the underlying driver I found it actually enumerate 3 interfaces, but go-ethereum usbwallet hub arbitrarily picks one based on the usageID.
Tests
Manually tested
Additional context
We use this lib in the upstream https://github.com/ethereum-optimism/eip712sign